Dwarf Fortress Bug Tracker - Dwarf Fortress
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0001290Dwarf FortressDwarf Mode -- Itemspublic2010-04-18 05:122010-06-09 07:56
ReporterJiri Petru 
Assigned ToToady One 
PriorityhighSeveritymajorReproducibilityhave not tried
StatusresolvedResolutionfixed 
PlatformOSOS Version
Product Version0.31.03 
Target VersionFixed in Version0.31.06 
Summary0001290: Soldiers trying to wear equipment already being worn by invading goblins
DescriptionMy military using the default uniforms blatantly refused to pick up pieces of equipment. Upon a bit of searching, I found out they were assigned equipment that was currently being worn by goblins. Obviously, they were unable to pick it up.

Experienced this with:
- Invading ambushers
- Friendly post-reclaim goblins, courtesy of a different bug
- Caged ambushers (which is especially annoying since there's no easy way how to manually forbid their stuff)

I haven't tried this with merchants because my arsenal dwarf wasn't working when merchants were there. Also I can't confirm this happens every time, because I haven't tried.

This seems like an easy fix - just make it so the equipment of creatures not under your control is forbidden by default, until it is dropped.
Steps To Reproduce
Additional InformationFor players: make sure you manually forbid all stuff carried by creatures that stay on your map (look in the inventory - item details - F). I recommend doing the same with invaders, though it is a huge bother. The bug occurs only when your arsenal dwarf is working, so if you don't forbid invaders' stuff, just don't let him work during an invasion.
Tagsforbidden item, item, weapon
Relationships
child of 0000501resolved Toady One Military dwarfs drop equipment because traders have better 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2010-04-18 05:12Jiri PetruNew Issue
2010-04-18 06:47Logical2uNote Added: 0004043
2010-04-18 07:17Jiri PetruNote Added: 0004049
2010-04-18 08:01Jiri PetruNote Added: 0004051
2010-04-18 08:04RusAnonNote Added: 0004052
2010-04-18 08:10Jiri PetruNote Added: 0004054
2010-04-18 08:15Jiri PetruNote Edited: 0004051bug_revision_view_page.php?bugnote_id=0004051#r1353
2010-04-18 10:31FootkerchiefNote Added: 0004059
2010-04-18 10:33FootkerchiefRelationship addedchild of 0000501
2010-04-18 10:33FootkerchiefNote Edited: 0004059bug_revision_view_page.php?bugnote_id=0004059#r1355
2010-04-18 10:35KennelTag Attached: forbidden item
2010-04-18 10:35KennelTag Attached: item
2010-04-18 10:35KennelTag Attached: weapon
2010-04-18 10:35FootkerchiefSummaryInvaders' and friendlies' equipment isn't forbidden by default => Soldiers trying to wear equipment already being worn by invading goblins
2010-04-18 10:53FootkerchiefIssue Monitored: Footkerchief
2010-04-18 11:13FootkerchiefNote Edited: 0004059bug_revision_view_page.php?bugnote_id=0004059#r1358
2010-04-18 12:15Jiri PetruNote Added: 0004087
2010-04-18 12:34FootkerchiefNote Added: 0004090
2010-04-18 14:07Jiri PetruNote Added: 0004108
2010-06-08 04:29Toady OneNote Added: 0007922
2010-06-08 04:29Toady OneStatusnew => resolved
2010-06-08 04:29Toady OneFixed in Version => 0.31.06
2010-06-08 04:29Toady OneResolutionopen => fixed
2010-06-08 04:29Toady OneAssigned To => Toady One
2010-06-09 06:45Toady OneStatusresolved => closed
2010-06-09 07:56FootkerchiefStatusclosed => resolved

Notes
(0004043)
Logical2u   
2010-04-18 06:47   
So in my game all the stuff goblins carry is auto-forbidden.

Are you sure you didn't change some "Forbid" settings? Or use the stocks screen too generously?
(0004049)
Jiri Petru   
2010-04-18 07:17   
Hmmm.... thinking about it, I may have unforbidden the equipment of my friendly goblins right after reclaim, though I don't recall doing it. I've certainly never unforbidden items of invaders, and yet my dwarves tried to use their (unforbidden) stuff. Perhaps it was an one-time glitch, I don't know. Will report once I get invaders again.

This may have something to do with the forbid settings in options, but that would be a bug anyway. The options should affect whether items get forbidden AFTER killing an invader, not before.
(0004051)
Jiri Petru   
2010-04-18 08:01   
(edited on: 2010-04-18 08:15)
On a related note: dwarves can be assigned equipment that belongs to traders... ie. that lies in the trade depot but is not yet yours. They can't pick it up though, which results in unarmed soldiers.
(0004052)
RusAnon   
2010-04-18 08:04   
Theres according setting in 'dwarf orders' section. You should check that it is set to 'forbid'.
(0004054)
Jiri Petru   
2010-04-18 08:10   
You mean the "forbid options" with the note that "all forbidding occurs at the time of dead?" But I'm not talking about equipment that drops from corpses. I'm talking about equipment that's carried by someone well alive.
(0004059)
Footkerchief   
2010-04-18 10:31   
(edited on: 2010-04-18 11:13)
The bug is that they're trying to wear clothing that's already worn by someone else who isn't going to drop it. Nothing to do with it being forbidden or not. See the previous report, 0000501.

If you have a save where a soldier is assigned equipment that a living goblin is currently wearing, you should probably upload it to http://dffd.wimbli.com/ [^]
(0004087)
Jiri Petru   
2010-04-18 12:15   
I don't have such a save with active ambushers but I have one where a soldier is assigned a crossbow that's carried by a caged goblin. Does it count? :)
(0004090)
Footkerchief   
2010-04-18 12:34   
Yup. I half suspect that this is the kind of problem Toady won't need a save for, but it definitely won't hurt.
(0004108)
Jiri Petru   
2010-04-18 14:07   
Well then, here it is. The marksdwarf named Shem has been assigned a (copper bow). Viewing the stocks screen, the only (copper bow) there is is being held by a goblin archer trapped in cage.

http://dffd.wimbli.com/file.php?id=2146 [^]
(0007922)
Toady One   
2010-06-08 04:29   
This should be fixed for 0.31.06. Generally the auto-forbid on incoming inventories would handle it, but I've put in a separate check now.