Dwarf Fortress Bug Tracker - Dwarf Fortress
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0004408Dwarf FortressReactionspublic2011-03-31 10:352016-05-13 00:06
ReporterKnight Otu 
Assigned ToToady One 
PrioritylowSeverityminorReproducibilityalways
StatusresolvedResolutionfixed 
PlatformOSOS Version
Product Version0.31.25 
Target VersionFixed in Version0.43.03 
Summary0004408: Decoration reactions never result in quality decorations
DescriptionReactions that add an improvement to an object, like the one I posted at 0004378, never result in quality decorations. I've tested this in adventure mode via a knapping reactions and a knapping demigod, and in Dwarf mode via a stonecraft reaction, in both cases adding stone spikes to an object of any kind.
Steps To ReproduceAdd a reaction with the IMPROVEMENT tag as per the linked issue that you can easily repeat, and repeat using it.
Additional Information
TagsNo tags attached.
Relationships
related to 0004378resolved Toady One Decorating with adventure mode reactions results in "You ... make nothing of note" 
related to 0004221resolved Toady One Adventure mode reactions no longer create quality items 
related to 0004409resolved Toady One Creating masterwork in adventure mode results in history line "created a masterful item for at an unknown site (or wrong site)" 
related to 0004577resolved Toady One Rust on Glazer skill isn't removed with practice, skill can't increase past Proficient 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2011-03-31 10:35Knight OtuNew Issue
2011-03-31 11:04FootkerchiefRelationship addedrelated to 0004378
2011-03-31 11:05FootkerchiefRelationship addedrelated to 0004221
2011-03-31 12:26FootkerchiefRelationship addedrelated to 0004409
2012-03-19 07:10FootkerchiefRelationship addedrelated to 0004577
2012-03-19 14:15NW_KohakuNote Added: 0021606
2016-05-13 00:06Toady OneStatusnew => resolved
2016-05-13 00:06Toady OneFixed in Version => Next Version
2016-05-13 00:06Toady OneResolutionopen => fixed
2016-05-13 00:06Toady OneAssigned To => Toady One

Notes
(0021606)
NW_Kohaku   
2012-03-19 14:15   
This problem appears to be because of IMPROVEMENT not respecting SKILL in any way, as per 0004577, and IMPROVEMENT also does not respect the number of reagents reserved for the IMPROVEMENT. (You only improve one item with the IMPROVEMENT token, regardless of number of reagents. Multiple IMPROVEMENTs only improve the same item multiple times.)

A savefile with a modded reaction that shows these problems with a legendary crafter making and improving items - http://dffd.wimbli.com/file.php?id=5932 [^]