Dwarf Fortress Bug Tracker - Dwarf Fortress
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0005021Dwarf FortressDwarf Mode -- Tradepublic2012-01-12 20:472016-05-06 16:24
ReporterGreymane 
Assigned ToToady One 
PrioritynormalSeverityminorReproducibilityalways
StatusresolvedResolutionfixed 
PlatformOSOS Version
Product Version0.31.25 
Target VersionFixed in Version0.43.01 
Summary0005021: "Masterwork has been lost" when merchants leave with traded items
DescriptionAs soon as visiting merchants leave the map, masterwork items traded to merchants are reported as stolen ('A masterwork of [dwarf] has been lost!') with accompanying negative thoughts for the creator. Have so far tested it on crafts of all kinds (mugs included), nest boxes, weapons, ammo, bins, and barrels.
Steps To ReproduceTrade a masterwork quality item to any merchant and wait for them to leave the map with the item.
Additional InformationSaves:
http://dffd.bay12games.com/file.php?id=11784 [^] (0.42.06)
http://dffd.bay12games.com/file.php?id=11787 [^] (0.42.06)
http://dffd.bay12games.com/file.php?id=11859 [^] (0.42.06)
Tags0.42.06
Relationships
has duplicate 0009576resolved lethosor Sold master quality items reported as "lost masterworks" upon merchants leaving the map 
has duplicate 0009691resolved Knight Otu Masterworks lost through trade 
related to 0003169needs feedback Footkerchief Bone carvers suffer art defacement when somebody leaves the map with stuck-in masterpiece bolts 
related to 0005441new  Modded Civ with Flee/Hide Interaction triggers Ambush pause with diplomat 
related to 0005442new  Traders leaving map with their own caged Animal triggers snatcher pause 
related to 0009780resolved Toady One Traded masterwork meals result in "Masterwork has been lost" message 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2012-01-12 20:47GreymaneNew Issue
2012-01-12 22:22FootkerchiefRelationship addedrelated to 0003169
2012-01-13 05:06KogutNote Added: 0019372
2012-01-13 06:02QuietustNote Added: 0019374
2012-01-13 07:01FootkerchiefTag Attached: AWAITING UPDATE
2012-01-13 09:14DwarfuNote Added: 0019378
2012-01-13 14:31GreymaneNote Added: 0019386
2012-01-13 14:42GreymaneTag Attached: UPDATE GIVEN
2012-01-13 15:57GreymaneNote Edited: 0019386bug_revision_view_page.php?bugnote_id=0019386#r7260
2012-01-13 16:27FootkerchiefTag Detached: AWAITING UPDATE
2012-01-13 16:27FootkerchiefTag Detached: UPDATE GIVEN
2012-01-13 16:27FootkerchiefSummaryTraded Masterworks Count As Stolen => "Masterwork has been lost" when merchants leave with traded items
2012-01-16 04:25KogutNote Added: 0019396
2012-01-16 15:44GreymaneNote Added: 0019398
2012-02-25 12:45FootkerchiefRelationship addedrelated to 0005441
2012-02-25 12:46FootkerchiefRelationship addedrelated to 0005442
2014-12-31 05:05ptb_ptbNote Added: 0031611
2014-12-31 07:54FootkerchiefNote Added: 0031615
2014-12-31 07:54FootkerchiefAssigned To => Footkerchief
2014-12-31 07:54FootkerchiefStatusnew => needs feedback
2015-01-01 01:57vomovNote Added: 0031626
2015-01-01 02:44ptb_ptbNote Added: 0031628
2015-01-02 10:45DetrosNote Added: 0031640
2015-01-02 10:45DetrosIssue Monitored: Detros
2015-01-05 03:43vomovNote Added: 0031698
2015-01-05 03:43vomovIssue Monitored: vomov
2015-01-05 09:02DetrosNote Added: 0031700
2015-01-05 17:00FootkerchiefNote Added: 0031720
2015-01-05 17:00FootkerchiefStatusneeds feedback => resolved
2015-01-05 17:00FootkerchiefResolutionopen => unable to reproduce
2016-03-16 14:16VitalArtIssue Monitored: VitalArt
2016-03-16 14:16VitalArtIssue End Monitor: VitalArt
2016-03-16 14:28lethosorRelationship addedhas duplicate 0009576
2016-03-16 14:28lethosorIssue Monitored: Button
2016-03-16 14:28lethosorIssue Monitored: Sarmatian123
2016-03-16 14:28lethosorIssue Monitored: madman256
2016-03-16 14:29lethosorNote Added: 0034860
2016-03-16 14:29lethosorStatusresolved => needs feedback
2016-03-16 14:29lethosorResolutionunable to reproduce => reopened
2016-03-16 14:31lethosorAdditional Information Updatedbug_revision_view_page.php?rev_id=14062#r14062
2016-03-18 14:05SpoCk0nd0peNote Added: 0034872
2016-03-18 19:20Sarmatian123Tag Attached: 0.42.06
2016-03-19 08:40seeschlossNote Added: 0034874
2016-04-02 17:28DaliTimelordNote Added: 0034965
2016-04-07 23:52AussiemonNote Added: 0034984
2016-04-15 02:16Knight OtuStatusneeds feedback => confirmed
2016-04-15 02:17Knight OtuRelationship addedhas duplicate 0009691
2016-05-06 16:24Toady OneStatusconfirmed => resolved
2016-05-06 16:24Toady OneFixed in Version => Next Version
2016-05-06 16:24Toady OneResolutionreopened => fixed
2016-05-06 16:24Toady OneAssigned ToFootkerchief => Toady One
2016-05-09 23:47ButtonIssue End Monitor: Button
2016-05-29 19:36DwarfuRelationship addedrelated to 0009780
2016-12-22 07:30AxDeathIssue Monitored: AxDeath
2018-12-18 18:57Sarmatian123Issue End Monitor: Sarmatian123

Notes
(0019372)
Kogut   
2012-01-13 05:06   
Please, upload savegame (it never happened in my game)
(0019374)
Quietust   
2012-01-13 06:02   
By any chance are you trading with a (modded) Kobold civilization?
(0019378)
Dwarfu   
2012-01-13 09:14   
Reminder sent to: Greymane

Can you update this report with a save (zip you DF/data/save/region folder and upload it to http://dffd.wimbli.com [^] and post a link in the bug report) and let us know if you are using any mods (such as a modded kobold civ, etc).
(0019386)
Greymane   
2012-01-13 14:31   
(edited on: 2012-01-13 15:57)
http://dffd.wimbli.com/file.php?id=5360 [^]

Save is up. I AM using mods, nameless homebrew stuff that does include a couple alterations to the Kobold civilization.

Oddly, while I had seen this happen in completely clean, unmodded worlds before I started modding, I actually can't seem to get it to repeat in a clean game anymore. Might have jumped the gun on a bug report, if it's the fault of the mods.

EDIT: Just to specifically address the question Quietust asked (which I had misread at first), the trading in question is not with Kobolds, who are not modded for trade (just a few equipment and job related things). Trade is still only with dwarves, elves, and humans and the bug crops up with all of them.
(0019396)
Kogut   
2012-01-16 04:25   
Are you playing as kobold civ?
(0019398)
Greymane   
2012-01-16 15:44   
Kogut: Belatedly, nope. Just dwarves. In most of the worlds/forts it happened in, there weren't even any kobolds because they'd all died out. Whatever was causing it wasn't kobold-related.
(0031611)
ptb_ptb   
2014-12-31 05:05   
I haven't seen this in DF 0.40.~~ Maybe it can be closed?
(0031615)
Footkerchief   
2014-12-31 07:54   
Anyone able to reproduce this with or without mods?
(0031626)
vomov   
2015-01-01 01:57   
I can't seem to reproduce this, because I can't trade masterwork stuff (not even through messing around with bins), which I think is intended behaviour (maybe for now, but still intended). I've not seen this issue for quite some time, so I suspect it can be closed.
(0031628)
ptb_ptb   
2015-01-01 02:44   
@vomov Not being able to trade Artifacts is as intended. Not being able to trade Masterwork (would be) a bug.
(0031640)
Detros   
2015-01-02 10:45   
No, Footkerchief. I am selling masterful ☼trap component☼s to dwarves and humans in 40.23 and neither such message nor bad thoughts of my carpenters noted.
(0031698)
vomov   
2015-01-05 03:43   
@ptb_ptb: mixed the terms 'Masterwork' and 'Artefact', whoops! (the negative thought threw me off)

Selling or getting rid of Masterwork stuff isn't a problem, as far as I can see; I've been deforesting aggressively and selling masterwork stuff for quite some time now, without issues.

Artefacts being non-tradable and the bad thoughts etc. resulting from a loss seems to be working as intended.
(0031700)
Detros   
2015-01-05 09:02   
So, can this be closed as "no more in current version"/"maybe caused by a mod" or something like that, at least until somebody manages to reproduce it in 0.40.20 or higher version?
(0031720)
Footkerchief   
2015-01-05 17:00   
That seems reasonable.

If anyone has a save that reproduces this problem in the latest version, please upload it to http://dffd.wimbli.com/ [^] and PM a manager on the forums (or reopen the report).
(0034860)
lethosor   
2016-03-16 14:29   
Reopened per 0009576 and http://www.bay12forums.com/smf/index.php?topic=52185.msg6876977#msg6876977 [^]

Save from VitalArt on the forums: http://dffd.bay12games.com/file.php?id=11859 [^]

Saves from 0009576:
http://dffd.bay12games.com/file.php?id=11784 [^]
http://dffd.bay12games.com/file.php?id=11787 [^]
(0034872)
SpoCk0nd0pe   
2016-03-18 14:05   
I just wanted to report it happened in my fort too. Do you still need another save?
(0034874)
seeschloss   
2016-03-19 08:40   
Just in case it can be useful, here's a save where this happened to me:

http://dffd.bay12games.com/file.php?id=11871 [^]

On a completely unmoded game.
(0034965)
DaliTimelord   
2016-04-02 17:28   
Also happened to me after the merchants left the map.

http://dffd.bay12games.com/file.php?id=11911 [^]

Unmodded, now with fancy screenshots!
(0034984)
Aussiemon   
2016-04-07 23:52   
In case it might assist further, here is another save, taken just before the traders leave the map with the "lost" masterwork.

http://dffd.bay12games.com/file.php?id=11922 [^]