Dwarf Fortress Bug Tracker - Dwarf Fortress
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0005366Dwarf FortressTechnical -- Input/Keybinding/Macrospublic2012-02-21 07:162012-02-22 14:33
ReporterGreiger 
Assigned ToBaughn 
PrioritynormalSeverityminorReproducibilityalways
StatusresolvedResolutionfixed 
PlatformOSOS Version
Product Version0.34.02 
Target VersionFixed in Version0.34.03 
Summary0005366: Bizarre macro behavior
DescriptionSaving a macro does not stop recording, playing that macro after saving can cause loss of game control.
Steps To ReproduceHit ctrl-r to create a macro and put in some basic commands, hit ctrl-s to save it. Note that the recording indicator is still on. Hold ctrl-p to play the macro afterwards. Note how the game is now simultaneously recording and playing the macro.

This can cause the game to go out of control, as the macro system seems to record and play itself repeatedly. A quick tap of the play button will often stop playing after a moment, but when the play button is held for a few seconds it seems to snowball out of control quickly.
Additional Information
TagsNo tags attached.
Relationships
has duplicate 0002571resolved lethosor Accidentally trying to run a macro while you are recording causes an infinite input loop 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2012-02-21 07:16GreigerNew Issue
2012-02-21 07:31GreigerNote Added: 0020373
2012-02-21 07:35FootkerchiefStatusnew => assigned
2012-02-21 07:35FootkerchiefAssigned To => Baughn
2012-02-21 07:35FootkerchiefSummaryBizzare Macro behavior => Bizarre macro behavior
2012-02-21 07:35GreigerNote Edited: 0020373bug_revision_view_page.php?bugnote_id=0020373#r7591
2012-02-21 07:36FootkerchiefNote Added: 0020375
2012-02-22 14:31BaughnNote Added: 0020492
2012-02-22 14:31BaughnStatusassigned => resolved
2012-02-22 14:31BaughnFixed in Version => Next Version
2012-02-22 14:31BaughnResolutionopen => fixed
2012-02-22 14:33BaughnNote Added: 0020494
2015-01-19 16:25lethosorRelationship addedhas duplicate 0002571

Notes
(0020373)
Greiger   
2012-02-21 07:31   
(edited on: 2012-02-21 07:35)
Actually, it seems holding the play key down at all to play a macro results in complete loss of game control. I imported a "down, enter, enter" macro from .31 and the macro would not stop after it was played.

This occurred in the trade screen when attempting to buy large amounts of food.
(0020375)
Footkerchief   
2012-02-21 07:36   
Reminder sent to: Baughn

Macros in simultaneous record/playback or something.
(0020492)
Baughn   
2012-02-22 14:31   
Oh, neat! I didn't realize it would do that, though it's obvious in retrospect.

I've changed the behaviour so it'll stop recording when you press ctrl-p. To the degree anyone would *want* the current behaviour, I'll deal with that using better macro keys when possible.
(0020494)
Baughn   
2012-02-22 14:33   
Actually, let's make that "temporarily stop recording while playing it back", so you'll be able to see how it works so far and then record some more.