0000404: Legends XML export produces malformed XML

View Issue Details [ Jump to Notes ]

[ Issue History ] [ Print ]

Project

Category

View Status

Date Submitted

Last Update

0000404

Dwarf Fortress

Legends Mode -- History Export

public

2010-04-04 08:45

2010-12-09 17:38

Reporter

jfs

Assigned To

Toady One

Priority

low

Severity

major

Reproducibility

have not tried

Status

resolved

Resolution

fixed

Platform

OS Version

Product Version

0.31.01

Target Version

Fixed in Version

0.31.13

Summary

0000404: Legends XML export produces malformed XML

Description

The XML file exported from Legends mode is illegal/not well-formed.
XML files must have a single top-level element that is parent of everything else. The file produced by DF has multiple elements at the top level, for example "regions", "underground_regions" and "sites" are all elements at top level.

The solution will be to wrap everything (except the <?xml?> prologue) inside a single top-level element, such as <world></world>.

I believe most XML parsers will bail on the file as it is now. (At least MSXML does: Try opening the file in Internet Explorer and scroll to the bottom, where you should see an error message.)

Additional Information

See XML 1.0 recommendation section 2.1: http://www.w3.org/TR/xml/#sec-well-formed [^]

Tags

legends, RESOLVED

Attached Files

Relationships

Notes
(0000971) SirPenguin (reporter) 2010-04-04 18:32	Just wanted to confirm this, though of course he did say that the feature was unfinished.

(0005861) jfs (reporter) 2010-05-01 16:21	Just checked, this is still an issue in 0.31.03. Tested with a freshly generated pocket region.

(0005868) smjjames (reporter) 2010-05-01 17:37	Yea, Toady said that the export to xml isn't actually working yet.

(0013020) Knight Otu (manager) 2010-09-27 05:09	As of 31.13, the exported xml has a wrapping <df_world> </df_world> element.

(0013264) jfs (reporter) 2010-10-08 10:13	I can confirm that this bug is fixed.

Issue History
Date Modified	Username	Field	Change
2010-04-04 08:45	jfs	New Issue
2010-04-04 17:25	Qloos	Tag Attached: legends
2010-04-04 18:32	SirPenguin	Note Added: 0000971
2010-04-05 04:11	Skibiliano	Issue Monitored: Skibiliano
2010-05-01 16:21	jfs	Note Added: 0005861
2010-05-01 17:37	smjjames	Note Added: 0005868
2010-08-30 02:22	Phydaux	Issue Monitored: Phydaux
2010-09-27 05:09	Knight Otu	Note Added: 0013020
2010-10-08 10:13	jfs	Note Added: 0013264
2010-10-08 10:13	jfs	Tag Attached: RESOLVED
2010-12-09 17:38	Footkerchief	Status	new => resolved
2010-12-09 17:38	Footkerchief	Fixed in Version	=> 0.31.13
2010-12-09 17:38	Footkerchief	Resolution	open => fixed
2010-12-09 17:38	Footkerchief	Assigned To	=> Toady One