Mantis Bug Tracker
Main | My View | View Issues | Change Log | Roadmap
  

View Issue Details [ Jump to Notes ] [ Issue History ] [ Print ]
IDProjectCategoryView StatusDate SubmittedLast Update
0007032Dwarf FortressDwarf Mode -- Jobs, Farming/Farmer's Workshoppublic2014-07-10 23:592014-08-14 23:49
Reporterdarkness100 
Assigned ToToady One 
PrioritynormalSeveritytweakReproducibilityalways
StatusresolvedResolutionfixed 
PlatformOSWindos 7OS Version
Product Version0.40.02 
Target VersionFixed in Version0.40.09 
Summary0007032: PROCESS_PLANT_TO_BAG reaction does not produce seeds
DescriptionThe reaction of processing plant to bag don't produce any rock nut.
TagsIntentional/Expected?, Probable Quick Fix, raw files
Attached Files

- Relationships
has duplicate 0007094resolvedDwarfu Disappearing Rock Nuts 
has duplicate 0007187resolvedFootkerchief Quarry bushes don't produce seeds 
has duplicate 0009110resolvedlethosor Quarry Bushes do not produce Rock Nuts 

-  Notes
(0025702)
Dwarfu (manager)
2014-07-11 00:35

 The new reaction PROCESS_PLANT_TO_BAG in reaction_other.txt does not have a seed as a product. In previous version this hard-coded reaction produced a seed. Should probably be matched with the brewing reactions to produce a seed.
(0025712)
darkness100 (reporter)
2014-07-11 01:12

 I think I solve the problem. The raw file of PROCESS_PLANT_TO_BAG should be added a line to produce a seed. And the raw file of quarry bush should be added a line to define the SEED_MAT of quarry bush.
(0025722)
HmH (reporter)
2014-07-11 02:48

 Additionally, the reaction produces 5 leaves regardless of how many bushes are used since the bag doesn't have [DOES_NOT_DETERMINE_PRODUCT_AMOUNT]. Adding that tag solves the problem.
(0026096)
crossmr (reporter)
2014-07-13 00:53

 This is possibly related. It seems my pig tails did the same thing. I had some growing, actually it seemed a couple years, but suddenly now my seeds are gone.
(0026448)
JoeJoe (reporter)
2014-07-15 03:43

 Yeah, I've had my cave wheat disappear once, and now my sweet pods and rock nuts are gone (even though I updated the raws).
(0027485)
Quietust (reporter)
2014-07-25 05:54
edited on: 2014-07-25 05:55

 The solution to this one is simple enough:


    [PRODUCT:100:1:SEEDS:NONE:GET_MATERIAL_FROM_REAGENT:plant:SEED_MAT]
    [PRODUCT:25:1:SEEDS:NONE:GET_MATERIAL_FROM_REAGENT:plant:SEED_MAT]
    [PRODUCT:25:1:SEEDS:NONE:GET_MATERIAL_FROM_REAGENT:plant:SEED_MAT]


This exactly matches behavior for eating plants (start with 1 seed, 1/2 chance to increase to 2 seeds, and 1/8 chance to increase to 3 seeds IF it didn't choose 2), and should probably be used with the brewing reactions as well for consistency with older versions.
(0027723)
Dwarfu (manager)
2014-07-27 15:19

 Not sure seeds work the same now, though I can't say I paid much attention to it before, but even though the seed products for brewing are:
[PRODUCT:100:1:SEEDS:NONE:GET_MATERIAL_FROM_REAGENT:plant:SEED_MAT],
it is 100% per plant in the stack...a stack of plant[4] is producing 4 seeds for me.
(0027973)
Kanddak (reporter)
2014-07-30 12:12
edited on: 2014-07-30 12:13

 It's been a long time since I've mucked around with the raws, so for readers in similar circumstances, here's a more detailed description of how I fixed my raws using HmH, Quietust, and darkness100's patches.

1. The files you need to change are in raw/objects. This will fix the issue for any new worlds generated after the change. To fix it in existing worlds, you need to get into data/save/regionx/raw/objects, where regionx is the name of your save.

2. Open reaction_other.txt and scroll down to "[REACTION:PROCESS_PLANT_TO_BAG]", the last reaction in the file.
Inside the indented block opened with "[REAGENT:bag:1:BOX:NONE:NONE:NONE]", append the line "[DOES_NOT_DETERMINE_PRODUCT_AMOUNT]".
At the end of the reaction, indented only one level, insert "[PRODUCT:100:1:SEEDS:NONE:GET_MATERIAL_FROM_REAGENT:plant:SEED_MAT]" and, optionally, two copies of "[PRODUCT:25:1:SEEDS:NONE:GET_MATERIAL_FROM_REAGENT:plant:SEED_MAT]".

3. Open plant_standard.txt and scroll down to "[PLANT:BUSH_QUARRY]", the fifth plant in the file.
Inside the first indented block, the one opened with "[USE_MATERIAL_TEMPLATE:STRUCTURAL:STRUCTURAL_PLANT_TEMPLATE]", append the line "[MATERIAL_REACTION_PRODUCT:SEED_MAT:LOCAL_PLANT_MAT:SEED]".
(0028158)
toombs (reporter)
2014-08-02 12:59

 I turned Kanddak's instructions into a diff:

--- reaction_other.txt- 2014-08-02 03:38:33.318878918 -0400
+++ reaction_other.txt 2014-08-02 15:47:41.539514686 -0400
@@ -325,6 +325,10 @@
         [EMPTY]
         [BAG]
         [PRESERVE_REAGENT]
+ [DOES_NOT_DETERMINE_PRODUCT_AMOUNT]
     [PRODUCT:100:5:GET_ITEM_DATA_FROM_REAGENT:plant:BAG_ITEM]
         [PRODUCT_TO_CONTAINER:bag]
+ [PRODUCT:100:1:SEEDS:NONE:GET_MATERIAL_FROM_REAGENT:plant:SEED_MAT]
+ [PRODUCT:25:1:SEEDS:NONE:GET_MATERIAL_FROM_REAGENT:plant:SEED_MAT]
+ [PRODUCT:25:1:SEEDS:NONE:GET_MATERIAL_FROM_REAGENT:plant:SEED_MAT]
     [SKILL:PROCESSPLANTS]

Those responsible for packaging .40.05 for Linux should consider applying this to their package.
(0028241)
greycat (reporter)
2014-08-03 15:47

 Your patch is missing the part for the plant_standard.txt file.

--- ../../../x/df_linux/raw/objects/reaction_other.txt 2014-08-03 14:55:50.000000000 -0400
+++ reaction_other.txt 2014-08-03 18:43:37.903971931 -0400
@@ -325,6 +325,8 @@
         [EMPTY]
         [BAG]
         [PRESERVE_REAGENT]
+ [DOES_NOT_DETERMINE_PRODUCT_AMOUNT]
     [PRODUCT:100:5:GET_ITEM_DATA_FROM_REAGENT:plant:BAG_ITEM]
         [PRODUCT_TO_CONTAINER:bag]
+ [PRODUCT:100:1:SEEDS:NONE:GET_MATERIAL_FROM_REAGENT:plant:SEED_MAT]
     [SKILL:PROCESSPLANTS]
--- ../../../x/df_linux/raw/objects/plant_standard.txt 2014-08-03 14:55:50.000000000 -0400
+++ plant_standard.txt 2014-08-03 18:44:44.640998605 -0400
@@ -210,6 +210,7 @@
         [MATERIAL_VALUE:2]
         [EDIBLE_VERMIN]
         [ITEM_REACTION_PRODUCT:BAG_ITEM:PLANT_GROWTH:LEAVES:LOCAL_PLANT_MAT:LEAF]
+ [MATERIAL_REACTION_PRODUCT:SEED_MAT:LOCAL_PLANT_MAT:SEED]
     [BASIC_MAT:LOCAL_PLANT_MAT:STRUCTURAL]
     [PICKED_TILE:5][PICKED_COLOR:7:0:0]
     [GROWDUR:500][VALUE:2]
(0028385)
toombs (reporter)
2014-08-05 10:21
edited on: 2014-08-05 13:50

 @greycat: Noted. That explains why I'm still leaking rock nuts. I found that getting a working diff file from pasting in the text we posted is endlessly fussy due to DOS line endings and tab characters, so this time, I'm posting a link to a ready-made patch with all of the right formatting.

http://s000.tinyupload.com/index.php?file_id=03211338005757724538 [^]

I have confirmed that this patch did work for me. Linux packagers: use this patch!
(0028821)
Kanddak (reporter)
2014-08-11 11:57

 Confirmed: The need to patch the raws before farming quarry bushes persists in 0.40.08.
(0028909)
MrC (reporter)
2014-08-12 18:52

 Please fix these entries into the raws before next update.

- Issue History
Date Modified Username Field Change
2014-07-10 23:59 darkness100 New Issue
2014-07-11 00:35 Dwarfu Note Added: 0025702
2014-07-11 00:35 Dwarfu Assigned To => Dwarfu
2014-07-11 00:35 Dwarfu Status new => acknowledged
2014-07-11 00:36 Dwarfu Summary Do not produce rock nuts => PROCESS_PLANT_TO_BAG reaction does not produce seeds
2014-07-11 00:36 Dwarfu Tag Attached: Intentional/Expected?
2014-07-11 01:12 darkness100 Note Added: 0025712
2014-07-11 02:48 HmH Note Added: 0025722
2014-07-11 17:34 Dwarfu Relationship added has duplicate 0007094
2014-07-13 00:29 Footkerchief Relationship added has duplicate 0007187
2014-07-13 00:53 crossmr Note Added: 0026096
2014-07-15 03:43 JoeJoe Note Added: 0026448
2014-07-15 18:05 Footkerchief Relationship added related to 0007337
2014-07-15 19:49 Dwarfu Relationship deleted related to 0007337
2014-07-25 03:23 Multipartite Issue Monitored: Multipartite
2014-07-25 05:54 Quietust Note Added: 0027485
2014-07-25 05:54 Quietust Note Edited: 0027485 View Revisions
2014-07-25 05:55 Quietust Note Edited: 0027485 View Revisions
2014-07-25 06:44 Footkerchief Tag Attached: Probable Quick Fix
2014-07-25 15:49 Kirkegaard Issue Monitored: Kirkegaard
2014-07-27 10:40 Kanddak Issue Monitored: Kanddak
2014-07-27 15:19 Dwarfu Note Added: 0027723
2014-07-30 12:12 Kanddak Note Added: 0027973
2014-07-30 12:13 Kanddak Note Edited: 0027973 View Revisions
2014-07-30 12:59 Dwarfu Status acknowledged => confirmed
2014-07-31 13:55 jpcosta Issue Monitored: jpcosta
2014-07-31 14:32 4maskwolf Issue Monitored: 4maskwolf
2014-08-02 12:59 toombs Note Added: 0028158
2014-08-03 15:47 greycat Note Added: 0028241
2014-08-05 10:21 toombs Note Added: 0028385
2014-08-05 10:45 toombs Note Edited: 0028385 View Revisions
2014-08-05 11:27 toombs Note Edited: 0028385 View Revisions
2014-08-05 13:50 toombs Note Edited: 0028385 View Revisions
2014-08-11 11:57 Kanddak Note Added: 0028821
2014-08-11 11:57 Kanddak Tag Attached: raw files
2014-08-12 18:52 MrC Note Added: 0028909
2014-08-13 12:07 Toady One Status confirmed => resolved
2014-08-13 12:07 Toady One Fixed in Version => Next Version
2014-08-13 12:07 Toady One Resolution open => fixed
2014-08-13 12:07 Toady One Assigned To Dwarfu => Toady One
2014-08-13 12:22 4maskwolf Issue End Monitor: 4maskwolf
2014-08-13 12:28 Kanddak Issue End Monitor: Kanddak
2014-08-13 13:52 Kirkegaard Issue End Monitor: Kirkegaard
2014-08-14 23:49 Multipartite Issue End Monitor: Multipartite
2015-11-06 05:47 Knight Otu Relationship added related to 0009110
2015-11-06 18:15 lethosor Relationship replaced has duplicate 0009110

Copyright © 2000 - 2010 MantisBT Group
Powered by Mantis Bugtracker