0007276: Worldgen arguments are not passed on correctly from the df script

View Issue Details [ Jump to Notes ]

[ Issue History ] [ Print ]

Project

Category

View Status

Date Submitted

Last Update

0007276

Dwarf Fortress

Technical -- General

public

2014-07-14 07:28

2014-08-20 12:10

Reporter

ChoHag

Assigned To

Footkerchief

Priority

none

Severity

trivial

Reproducibility

always

Status

resolved

Resolution

duplicate

Platform

Linux

OS Version

Product Version

0.40.03

Target Version

Fixed in Version

Summary

0007276: Worldgen arguments are not passed on correctly from the df script

Description

$* expands spaces in arguments, so this command:

./df -gen 1 RANDOM "MEDIUM ISLAND"

Ends up running this:

./libs/Dwarf_Fortress "-gen" "1" "RANDOM" "MEDIUM" "ISLAND"

Or from gamelog.txt:

*** STARTING NEW GAME ***
Command Line: -gen "1" "RANDOM" "MEDIUM" "ISLAND"
Command Line: World generation initiated.
Command Line: World generation parameter set MEDIUM not found -- using default.
Generating world using parameter set MEDIUM ISLAND

Additional Information

The fix is as trivial as the problem: Change $* to "$@" (with quotes) so the whole file reads:

#!/bin/sh
DF_DIR=$(dirname "$0")
cd "${DF_DIR}"
export SDL_DISABLE_LOCK_KEYS=1 # Work around for bug in Debian/Ubuntu SDL patch.
#export SDL_VIDEO_CENTERED=1 # Centre the screen. Messes up resizing.
./libs/Dwarf_Fortress "$@" # Go, go, go! :)

Tags

No tags attached.

Attached Files

Relationships

duplicate of

0006394

resolved

Toady One

"df" script does not pass command-line arguments correctly (i.e. for world generation) on OS X/Linux

Notes
(0029366) BenLubar (reporter) 2014-08-20 11:13	This has been fixed as of 0.40.09. Not sure how to notify someone to close it.

Issue History
Date Modified	Username	Field	Change
2014-07-14 07:28	ChoHag	New Issue
2014-07-14 08:59	Footkerchief	Summary	Arguments are not passed on correctly from the df script => Worldgen arguments are not passed on correctly from the df script
2014-08-20 11:13	BenLubar	Note Added: 0029366
2014-08-20 12:10	Footkerchief	Relationship added	duplicate of 0006394
2014-08-20 12:10	Footkerchief	Status	new => resolved
2014-08-20 12:10	Footkerchief	Resolution	open => duplicate
2014-08-20 12:10	Footkerchief	Assigned To	=> Footkerchief