0007747: Farm plot planting cut-off fails to work over the Winter->Spring boundary

Notes
(0027989) Kanddak (reporter) 2014-07-30 16:26	I can confirm this is happening to me too. Specifically, in late winter, nothing at all can be planted; everything shows as red in the farm plot menu.

(0028210) Quietust (reporter) 2014-08-03 06:03	This is a long-standing issue that dates back to 40d.

(0029187) i2amroy (reporter) 2014-08-17 12:13	Yeah, but as long as the game was bugged to not cut off planting at all the issue was "fixed". It made the planting cut-off one of those "it's not a bug, it's a feature" type things.

(0030806) Quietust (reporter) 2014-10-30 13:00 edited on: 2014-10-30 13:07	Looking at a disassembly, it appears to first check the season time, then whether your dwarves know it's dangerous to plant that crop at the end of that season, and then whether the plant is allowed to be planted during the next season. The problem is that if the current season is Winter, it entirely skips the 3rd check and returns "not safe to plant". The following untested binary patch should fix this for version 0.40.14 Win32 SDL: 0x073D4E : 80 FB 03 7D 07 -> 45 83 E5 03 90 0x073D56 : 11 -> 10 Rather than doing "if (season < 3 && allowed_seasons[season+1])", it now does "season = (season + 1) % 4; if (allowed_seasons[season])".

(0031006) Toady One (administrator) 2014-11-15 13:43	I think this was an ancient holdover from when farm plots used to just disappear in winter in the old 2D version. It should work for 0.40.17.