Mantis Bug Tracker

View Issue Details Jump to Notes ] Issue History ] Print ]
IDProjectCategoryView StatusDate SubmittedLast Update
0010274Dwarf FortressCreaturespublic2017-08-11 03:562022-03-02 15:23
Reporterlatias1290 
Assigned To 
PrioritynormalSeveritytweakReproducibilityalways
StatusnewResolutionopen 
PlatformPCOSWindowsOS Version7
Product Version0.43.05 
Target VersionFixed in Version 
Summary0010274: Some animal people have extra fingers
DescriptionBecause of a typo in the raws, certain types of animal people have extra fingers.

In c_variation_default.txt, on line 73-76:

    [CV_CONVERT_TAG]
        [CVCT_MASTER:BODY]
        [CVCT_TARGET:QUADRUPED_NECK]
        [CVCT_REPLACEMENT:HUMANOID_NECK:3FINGERS]

The 3FINGERS part causes animal people that already have front toes defined to gain three extra fingers, which can be seen when targeting specific body parts in adventure mode.
Additional Information- To fix this, remove replace [CVCT_REPLACEMENT:HUMANOID_NECK:3FINGERS] with [CVCT_REPLACEMENT:HUMANOID_NECK].

- QUADRUPED_HOOF creatures also have 3FINGERS, but they don't have toes to begin with, so it doesn't cause an issue.

- QUADRUPED creatures do not get this conversion, while QUADRUPED_NECK creatures do.
Tagseasily fixed, raw tweak
Attached Files

- Relationships

-  Notes
(0037257)
thrush_titan (reporter)
2017-12-07 12:50

I also noticed this while using the Dwarf Portrait utility. Screenshot: https://i.imgur.com/2KMHg7t.png [^]
(0039990)
hertggf (reporter)
2020-02-09 15:08

Bug is still present in 47.02, and still is a one-line fix.
(0040462)
spiral-king (reporter)
2020-04-13 16:23
edited on: 2020-04-13 16:24

The bug report and above comments claim this is a one-line, easy fix, but the proposed changes cause problems. From the error log, where the only thing changed from vanilla is the proposed fix:

*** Error(s) found in the file "raw/objects/creature_large_tropical.txt"
ELEPHANT_MAN:Tissue layer not added because no BP found: BY_CATEGORY:FINGER:NAIL
ELEPHANT_MAN:Tissue layer not added because no BP found: BY_CATEGORY:FINGER:NAIL
ELEPHANT_MAN:FEMALE:Attack SCRATCH seems to have correct format but could not find proper BPs in any caste, so not added
ELEPHANT_MAN:MALE:Attack SCRATCH seems to have correct format but could not find proper BPs in any caste, so not added
CAMEL_1_HUMP_MAN:Tissue layer not added because no BP found: BY_CATEGORY:FINGER:NAIL
CAMEL_1_HUMP_MAN:Tissue layer not added because no BP found: BY_CATEGORY:FINGER:NAIL
CAMEL_1_HUMP_MAN:FEMALE:Attack SCRATCH seems to have correct format but could not find proper BPs in any caste, so not added
CAMEL_1_HUMP_MAN:MALE:Attack SCRATCH seems to have correct format but could not find proper BPs in any caste, so not added
CAMEL_2_HUMP_MAN:Tissue layer not added because no BP found: BY_CATEGORY:FINGER:NAIL
CAMEL_2_HUMP_MAN:Tissue layer not added because no BP found: BY_CATEGORY:FINGER:NAIL
CAMEL_2_HUMP_MAN:FEMALE:Attack SCRATCH seems to have correct format but could not find proper BPs in any caste, so not added
CAMEL_2_HUMP_MAN:MALE:Attack SCRATCH seems to have correct format but could not find proper BPs in any caste, so not added
RHINOCEROS_MAN:Tissue layer not added because no BP found: BY_CATEGORY:FINGER:NAIL
RHINOCEROS_MAN:Tissue layer not added because no BP found: BY_CATEGORY:FINGER:NAIL
RHINOCEROS_MAN:FEMALE:Attack SCRATCH seems to have correct format but could not find proper BPs in any caste, so not added
RHINOCEROS_MAN:MALE:Attack SCRATCH seems to have correct format but could not find proper BPs in any caste, so not added
GIRAFFE_MAN:Tissue layer not added because no BP found: BY_CATEGORY:FINGER:NAIL
GIRAFFE_MAN:Tissue layer not added because no BP found: BY_CATEGORY:FINGER:NAIL
GIRAFFE_MAN:FEMALE:Attack SCRATCH seems to have correct format but could not find proper BPs in any caste, so not added
GIRAFFE_MAN:MALE:Attack SCRATCH seems to have correct format but could not find proper BPs in any caste, so not added

To me it doesn't look like this is fixed as easily as the bug report implies.

(0041230)
memzak (reporter)
2022-03-02 15:23

This bug is still a thing in version 47.05. I, too, noticed it in Dwarf Portrait. Perhaps it's not a one-line fix but a pretty easy one regardless. An example of such could be:

In body_default.txt:
    Add the new empty tag [BODY:0FINGERS]
In creature_large_tropical.txt:
    Add the 0FINGERS to the [BODY] tags of the ELEPHANT, CAMEL_1_HUMP, CAMEL_2_HUMP, RHINOCEROS, and GIRAFFE creatures.
In c_variation_default.txt, under [CREATURE_VARIATION:ANIMAL_PERSON]:
add the following:
[CV_CONVERT_TAG]
        [CVCT_MASTER:BODY]
        [CVCT_TARGET:0FINGERS]
        [CVCT_REPLACEMENT:3FINGERS]
and replace:
[CV_CONVERT_TAG]
        [CVCT_MASTER:BODY]
        [CVCT_TARGET:QUADRUPED_NECK]
        [CVCT_REPLACEMENT:HUMANOID_NECK:3FINGERS]
with:
[CV_CONVERT_TAG]
        [CVCT_MASTER:BODY]
        [CVCT_TARGET:QUADRUPED_NECK]

- Issue History
Date Modified Username Field Change
2017-08-11 03:56 latias1290 New Issue
2017-08-11 07:22 latias1290 Tag Attached: easily fixed
2017-08-12 06:05 Rafal99 Tag Attached: raw tweak
2017-12-07 12:50 thrush_titan Note Added: 0037257
2017-12-07 12:51 thrush_titan Issue Monitored: thrush_titan
2017-12-07 13:48 hertggf Issue Monitored: hertggf
2020-02-09 15:08 hertggf Note Added: 0039990
2020-04-13 16:23 spiral-king Note Added: 0040462
2020-04-13 16:24 spiral-king Note Edited: 0040462 View Revisions
2022-03-02 15:23 memzak Note Added: 0041230
2022-03-02 15:24 memzak Issue Monitored: memzak


Copyright © 2000 - 2010 MantisBT Group
Powered by Mantis Bugtracker