0011804: [MAX_MULTIPLIER:1] and stack size not respected by some modded reactions

View Issue Details [ Jump to Notes ]

[ Issue History ] [ Print ]

Project

Category

View Status

Date Submitted

Last Update

0011804

Dwarf Fortress

Dwarf Mode -- Jobs, General

public

2021-09-09 10:31

Reporter

Rekov

Assigned To

Priority

normal

Severity

minor

Reproducibility

always

Status

new

Resolution

open

Platform

Windows

OS Version

Product Version

0.47.05

Target Version

Fixed in Version

Summary

0011804: [MAX_MULTIPLIER:1] and stack size not respected by some modded reactions

Description

The [MAX_MULTIPLIER:1] token doesn't work consistently across all modded reactions, even when they are otherwise very similar.

My mod contains two very similar reactions, which both take CORPSEPIECE items as the reagent:

[REACTION:CARVE_BONE_BLOCKS]
    [NAME:carve bone Blocks]
    [DESCRIPTION:Requires 1 bone to produce 1 block.]
    [BUILDING:BONE_SHOP:CUSTOM_O]
    [REAGENT:bone:1:NONE:NONE:NONE:NONE]
        [USE_BODY_COMPONENT][ANY_BONE_MATERIAL][UNROTTEN]
    [PRODUCT:100:1:BLOCKS:NONE:GET_MATERIAL_FROM_REAGENT:bone:NONE]
    [MAX_MULTIPLIER:1]
    [SKILL:BONECARVE]

[REACTION:PROCESS_PLANT_FOLIAGE_TO_THREAD]
    [NAME:Process Plants (Foliage)]
    [DESCRIPTION:Process plant foliage sheared from a plant creature into usable thread.]
    [BUILDING:FARMER:CUSTOM_F]
    [REAGENT:foliage:1:NONE:NONE:NONE:NONE]
        [USE_BODY_COMPONENT]
        [HAS_MATERIAL_REACTION_PRODUCT:PRESS_PAPER_MAT]
        [UNROTTEN]
    [PRODUCT:100:1:THREAD:NONE:GET_MATERIAL_FROM_REAGENT:foliage:PRESS_PAPER_MAT]
        [PRODUCT_DIMENSION:15000]
    [MAX_MULTIPLIER:1]
    [SKILL:PROCESSPLANTS]

In the first reaction, the bone carver takes a whole stack of bones to the workshop. The reaction consumes only one bone from the stack, and produces a single bone block. I have similar reactions which take more bones, for example three bones for a table. The whole stack is never consumed, and only a single product is produced.

The second reaction takes a stack of CORPSEPIECE which has been sheared from a plant-based creature. In this case, the thresher takes a whole stack to the workshop. The whole stack is consumed, and only a single thread is produced.

I should note that this exact behavior occurs whether or not [MAX_MULTIPLIER:1] is present. So this bug could be that the token doesn't work, or that when the token is absent, a whole stack is consumed without producing a commensurate number of products.

I will also note that in the second reaction, the product type doesn't seem to matter. If I change it from THREAD to BLOCKS like in the first reaction, the same behavior is observed—the whole stack is consumed, and only a single product is produced.

Steps To Reproduce

https://dffd.bay12games.com/file.php?id=15654 [^]

In the provided save, add a "Process Plants (Foliage)" tasks to the Farmer's Workshop. For comparison, also add any of the tasks available at the Bone Carver's workshop.

A stack of stray shambling mound foliage [11] is available in the Farmer's workshop, and stray dog bone [12] in the nearby refuse stockpile for testing.

Issue History
Date Modified	Username	Field	Change
2021-09-09 10:31	Rekov	New Issue

Relationships

Notes
There are no notes attached to this issue.