0011810: sum of casts maximum BODY_SIZE prevents wood chopping

View Issue Details [ Jump to Notes ]

[ Issue History ] [ Print ]

Project

Category

View Status

Date Submitted

Last Update

0011810

Dwarf Fortress

Dwarf Mode -- Jobs, Assignment of Jobs

public

2021-10-03 11:13

2021-10-09 01:38

Reporter

enemy-of-christ

Assigned To

Priority

low

Severity

minor

Reproducibility

always

Status

new

Resolution

open

Platform

x86_64

Windows 10 Home (Cygwin)

OS Version

21H1+19043.1165

Product Version

0.47.05

Target Version

Fixed in Version

Summary

0011810: sum of casts maximum BODY_SIZE prevents wood chopping

Description

If I assign BODY_SIZE to all the castes and the sum of the caste's BODY_SIZE maximum values is <=86000 then *no* dwarf (regardless of age or caste) will be able to chop down trees.

So even if one caste has a [BODY_SIZE:*:*:72427] no dwarf from this cast will be able to chop wood, because the other caste has a [BODY_SIZE:*:*:12573], because 72427+12573<=86000.

If the sum of BODY_SIZE's is in the range [86001,86008] then wood chopping ability is undefined, sometimes it works, sometimes it does not.

If the sum of BODY_SIZE's is >=86009 then wood chopping apparently always works, even if one caste has a [BODY_SIZE:*:*:10000].

Have not tried with more than two castes, it may be an average as opposed to a sum.

Steps To Reproduce

$ git format-patch v0.47.05..BODY_SIZE_BUG
[...]

---
objects/creature_standard.txt | 22 ++++++++++++++++------
1 file changed, 16 insertions(+), 6 deletions(-)

diff --git a/objects/creature_standard.txt b/objects/creature_standard.txt
index 0b39bea..908e393 100644
--- a/objects/creature_standard.txt
+++ b/objects/creature_standard.txt
@@ -126,12 +126,6 @@ creature_standard
     [MENT_ATT_RANGE:MEMORY:450:950:1150:1250:1350:1550:2250] +
     [MENT_ATT_RANGE:SPATIAL_SENSE:700:1200:1400:1500:1600:1800:2500] ++

- These tags establish the growth phases of the creature's life. The format is (BODY_SIZE|<year>|<day>|<average size>).
-
- [BODY_SIZE:0:0:3000]
- [BODY_SIZE:1:168:15000]
- [BODY_SIZE:12:0:60000]
-
     These body modifiers give individual dwarves different characteristics. In the case of HEIGHT, BROADNESS and LENGTH, the modifier is also a percentage change to the BODY_SIZE of the individual creature. The seven numbers afterward give a distribution of ranges. Each interval has an equal chance of occurring.

     [BODY_APPEARANCE_MODIFIER:HEIGHT:75:95:98:100:102:105:125]
@@ -331,10 +325,26 @@ creature_standard
         [MULTIPLE_LITTER_RARE]
         To add beards, put square brackets around the following:
         BODY_DETAIL_PLAN:FACIAL_HAIR_TISSUE_LAYERS
+
+ <SUM_OF_CASTES_BODY_SIZE>(<NUMBER_OF_SUCCESS>,<NUMBER_OF_FAILURE>)
+ 85000(0,7)
+ 85001(1,1)
+ 85002(1,5)
+ 85003(3,5)
+ 85005(0,1)
+ 85009(9,0)
+ trying SUM(BODY_SIZE)=85000=72427+12573
+ [BODY_SIZE:0:0:3000]
+ [BODY_SIZE:98:0:3000]
+ [BODY_SIZE:99:0:72427]
+
     [CASTE:MALE]
         [MALE]
         [SET_BP_GROUP:BY_TYPE:LOWERBODY][BP_ADD_TYPE:GELDABLE]
         [BODY_DETAIL_PLAN:FACIAL_HAIR_TISSUE_LAYERS]
+ [BODY_SIZE:0:0:3000]
+ [BODY_SIZE:98:0:3000]
+ [BODY_SIZE:99:0:12573]

     This command lets you select all of the castes again.

--
2.33.0

Tags

No tags attached.

Attached Files

Relationships

Notes
(0041160) Bumber (reporter) 2021-10-05 06:53	Related to 0005812

(0041162) FantasticDorf (reporter) 2021-10-09 01:38	Battleaxes have a cm3 size requirement (like all weapons), typically in modding if you were to use a smaller race you would apply smaller weapons and tools, like small picks and hatchets to accomodate them. The modifiers do have a total effect on actual representative cm3 (rule of thumb while modding: x and y chart, length is x horizontal, height is y vertical and broadness is a sloped upward climbing x diagonal) but it'd be right to say its a bug if it isn't computed to the actual mean size of the creature.

Issue History
Date Modified	Username	Field	Change
2021-10-03 11:13	enemy-of-christ	New Issue
2021-10-05 06:53	Bumber	Note Added: 0041160
2021-10-09 01:38	FantasticDorf	Note Added: 0041162