0006544: Dwarf likes to consume Unknown Leaves

(0024905)
Gentlefood (reporter)
2014-07-07 20:12

http://i.imgur.com/yT9kpjR.png [^] Image of dwarf personality.

(0025614)
Dwarfu (manager)
2014-07-10 16:09

This was probably the quarry bush leaves, though there are many other plants now that have edible leaves...will leave this open for feedback.

(0025679)
Gentlefood (reporter)
2014-07-10 21:12

Since the saves are no longer compatible it won't be easy to test for this. I'll keep an eye out, but I can't think of an easy way to go about this.

(0025681)
Rafal99 (reporter)
2014-07-10 21:54
edited on: 2014-07-10 21:56

Try updating the raws in your 40.01 save with the fixed Quarry Bush raws from 40.02, then load the save in 40.01 and see if the description changed.

The only line that changed in the raw is:
[ITEM_REACTION_PRODUCT:BAG_ITEM:PLANT_GROWTH:LEAVES:LOCAL_PLANT_MAT:STRUCTURAL]
Which changed to:
[ITEM_REACTION_PRODUCT:BAG_ITEM:PLANT_GROWTH:LEAVES:LOCAL_PLANT_MAT:LEAF]

(0026000)
Dwarfu (manager)
2014-07-12 11:49

There's still a problem somewhere - I keep getting preferences for "likes to consume unknown leaves," but quarry bush is the only entry that contained that line, so it may just be the wonky preferences screen.

(0026060)
Gentlefood (reporter)
2014-07-12 17:50

Well trees do drop their leaves during the later seasons which appear on the ground as gather-able with the gather plants option iirc.

(0026647)
musicmastermsh (reporter)
2014-07-16 11:02

Found this as a preference in 40.03

(0027522)
Lich180 (reporter)
2014-07-25 12:15
edited on: 2014-07-25 12:16

I have a current save with one of the dwarves with this preference. The dwarf in question is named Saksul "O7" Zattthudsibrek, Axedwarf.

Save: http://dffd.wimbli.com/file.php?id=9147 [^]

(0027523)
Quietust (reporter)
2014-07-25 12:22
edited on: 2014-07-25 19:59

The preference in question in Lich180's savegame is for PLANT_GROWTH items with material/matgloss values of 423/139, which decodes to PLANT_MAT:PARADISE_NUT:FRUIT, or paradise nut tree fruit.

I can only assume that it's trying (and failing) to translate that to a GROWTH type (i.e. "paradise nut fruits").

As such, this bug has no relation to 0006659.

[edit]

Upon closer inspection of the item description logic, it looks like PLANT_GROWTH items are always expected to have the item's subtype set to the index of the plant growth in question (and also expects that the material will be in the 419-618 range, ensuring that the matgloss is a valid plant ID).

Given that information, there are actually two different bugs here that need to be fixed:

1. Unit preferences of type 2 (food) and item type 55 (PLANT_GROWTH) must specify a valid subtype to indicate the plant growth type - currently, they store the value -1.
2. The preferences display code needs to pass the item subtype stored inside the preference record into the "format item name" function - currently, it passes a literal value of -1.

(0027875)
Toady One (administrator)
2014-07-29 11:17

Should be fixed for 0.40.06. Old saves will still be affected.

Issue History
Date Modified	Username	Field	Change
2014-07-07 20:06	Gentlefood	New Issue
2014-07-07 20:06	Gentlefood	Issue Monitored: Gentlefood
2014-07-07 20:06	Gentlefood	Issue End Monitor: Gentlefood
2014-07-07 20:12	Gentlefood	Note Added: 0024905
2014-07-08 11:03	Footkerchief	Relationship added	related to 0006659
2014-07-10 16:09	Dwarfu	Note Added: 0025614
2014-07-10 16:09	Dwarfu	Assigned To	=> Dwarfu
2014-07-10 16:09	Dwarfu	Status	new => needs feedback
2014-07-10 21:12	Gentlefood	Note Added: 0025679
2014-07-10 21:12	Gentlefood	Status	needs feedback => assigned
2014-07-10 21:54	Rafal99	Note Added: 0025681
2014-07-10 21:56	Rafal99	Note Edited: 0025681	View Revisions
2014-07-10 23:07	Rafal99	Issue Monitored: Rafal99
2014-07-12 11:49	Dwarfu	Note Added: 0026000
2014-07-12 11:49	Dwarfu	Status	assigned => needs feedback
2014-07-12 17:50	Gentlefood	Note Added: 0026060
2014-07-12 17:50	Gentlefood	Status	needs feedback => assigned
2014-07-16 11:02	musicmastermsh	Note Added: 0026647
2014-07-16 11:28	Rafal99	Issue End Monitor: Rafal99
2014-07-25 12:15	Lich180	Note Added: 0027522
2014-07-25 12:16	Lich180	Note Edited: 0027522	View Revisions
2014-07-25 12:16	Lich180	Issue Monitored: Lich180
2014-07-25 12:22	Quietust	Note Added: 0027523
2014-07-25 12:22	Quietust	Note Edited: 0027523	View Revisions
2014-07-25 12:23	Quietust	Note Edited: 0027523	View Revisions
2014-07-25 14:28	Quietust	Note Edited: 0027523	View Revisions
2014-07-25 19:28	Dwarfu	Status	assigned => acknowledged
2014-07-25 19:29	Dwarfu	Relationship deleted	related to 0006659
2014-07-25 19:51	Quietust	Note Edited: 0027523	View Revisions
2014-07-25 19:59	Quietust	Note Edited: 0027523	View Revisions
2014-07-28 14:42	Dwarfu	Status	acknowledged => confirmed
2014-07-29 11:17	Toady One	Note Added: 0027875
2014-07-29 11:17	Toady One	Status	confirmed => resolved
2014-07-29 11:17	Toady One	Fixed in Version	=> Next Version
2014-07-29 11:17	Toady One	Resolution	open => fixed
2014-07-29 11:17	Toady One	Assigned To	Dwarfu => Toady One

Notes
(0024905) Gentlefood (reporter) 2014-07-07 20:12	http://i.imgur.com/yT9kpjR.png [^] Image of dwarf personality.

(0025614) Dwarfu (manager) 2014-07-10 16:09	This was probably the quarry bush leaves, though there are many other plants now that have edible leaves...will leave this open for feedback.

(0025679) Gentlefood (reporter) 2014-07-10 21:12	Since the saves are no longer compatible it won't be easy to test for this. I'll keep an eye out, but I can't think of an easy way to go about this.

(0025681) Rafal99 (reporter) 2014-07-10 21:54 edited on: 2014-07-10 21:56	Try updating the raws in your 40.01 save with the fixed Quarry Bush raws from 40.02, then load the save in 40.01 and see if the description changed. The only line that changed in the raw is: [ITEM_REACTION_PRODUCT:BAG_ITEM:PLANT_GROWTH:LEAVES:LOCAL_PLANT_MAT:STRUCTURAL] Which changed to: [ITEM_REACTION_PRODUCT:BAG_ITEM:PLANT_GROWTH:LEAVES:LOCAL_PLANT_MAT:LEAF]

(0026000) Dwarfu (manager) 2014-07-12 11:49	There's still a problem somewhere - I keep getting preferences for "likes to consume unknown leaves," but quarry bush is the only entry that contained that line, so it may just be the wonky preferences screen.

(0026060) Gentlefood (reporter) 2014-07-12 17:50	Well trees do drop their leaves during the later seasons which appear on the ground as gather-able with the gather plants option iirc.

(0026647) musicmastermsh (reporter) 2014-07-16 11:02	Found this as a preference in 40.03

(0027522) Lich180 (reporter) 2014-07-25 12:15 edited on: 2014-07-25 12:16	I have a current save with one of the dwarves with this preference. The dwarf in question is named Saksul "O7" Zattthudsibrek, Axedwarf. Save: http://dffd.wimbli.com/file.php?id=9147 [^]

(0027523) Quietust (reporter) 2014-07-25 12:22 edited on: 2014-07-25 19:59	The preference in question in Lich180's savegame is for PLANT_GROWTH items with material/matgloss values of 423/139, which decodes to PLANT_MAT:PARADISE_NUT:FRUIT, or paradise nut tree fruit. I can only assume that it's trying (and failing) to translate that to a GROWTH type (i.e. "paradise nut fruits"). As such, this bug has no relation to 0006659. [edit] Upon closer inspection of the item description logic, it looks like PLANT_GROWTH items are always expected to have the item's subtype set to the index of the plant growth in question (and also expects that the material will be in the 419-618 range, ensuring that the matgloss is a valid plant ID). Given that information, there are actually two different bugs here that need to be fixed: 1. Unit preferences of type 2 (food) and item type 55 (PLANT_GROWTH) must specify a valid subtype to indicate the plant growth type - currently, they store the value -1. 2. The preferences display code needs to pass the item subtype stored inside the preference record into the "format item name" function - currently, it passes a literal value of -1.

(0027875) Toady One (administrator) 2014-07-29 11:17	Should be fixed for 0.40.06. Old saves will still be affected.

Relationships