0008373: large cmv flashes black-on-red @ for large areas of the screen

(0030433)
BenLubar (reporter)
2014-09-28 15:45

Observation:

@ is CP437 0x40
red is the 4th color in Dwarf Fortress (ignoring intensities)
black is the 0th color in Dwarf Fortress

There's probably some uninitialized data being read somewhere.

(0030435)
Quietust (reporter)
2014-09-28 17:51
edited on: 2014-09-28 18:23

If you single-step through the movie, the frames with black-on-red-@ are all misaligned, drawing from some point in the middle of the screen and corrupting anything that would've been off the right edge (and with everything past the bottom edge shifted to the left). The bug described in 0003654 sounds similar to this.

(0030442)
BenLubar (reporter)
2014-09-28 22:36

I wonder if it has to do with how the file is compressed...

The file (and also pretty much every other Dwarf Fortress file) is compressed in chunks, with each chunk's uncompressed size being more or less constant. Maybe all the broken frames go over chunk boundaries.

(0031415)
BenLubar (reporter)
2014-12-21 12:35

screen capture of dwarf fortress: https://www.youtube.com/watch?v=fBVATWnlw1Y [^]
external encoder using the same cmv file: https://www.youtube.com/watch?v=c5CUZhpRryA [^]

(0031475)
lethosor (manager)
2014-12-25 18:19

You mentioned that this occurs with "large" movies in the title - does it occur with 80x25 movies at all? Have you noticed a minimum resolution where this occurs?

(0034247)
BenLubar (reporter)
2015-12-28 18:33
edited on: 2015-12-28 18:48

Okay, it seems I deleted the original repro when I was cleaning out some old stuff, so here's a new repro:

http://dffd.bay12games.com/file.php?id=6190 [^]

Pick any of the three files. They're all 91x34 and they all exibit the same behavior.

I've modified a UI experiment I was working on to play those CMVs and output a recording to last_record.cmv: http://dffd.bay12games.com/file.php?id=11574 [^]

The UI experiment can demonstrate that the CMV files are not corrupted.

(0034250)
BenLubar (reporter)
2015-12-28 20:11

Ok, looks like the third CMV file is actually corrupt, possibly from the screen size changing while it was recording, but I'm not sure. The first two are fine, though.

(0034277)
BenLubar (reporter)
2016-01-02 16:36

Here's a fixed version of the third CMV: http://dffd.bay12games.com/file.php?id=11577 [^] (it was indeed corrupted by screen size changing)

Issue History
Date Modified	Username	Field	Change
2014-09-28 15:30	BenLubar	New Issue
2014-09-28 15:32	BenLubar	Issue Monitored: BenLubar
2014-09-28 15:45	BenLubar	Note Added: 0030433
2014-09-28 17:51	Quietust	Note Added: 0030435
2014-09-28 18:23	Quietust	Note Edited: 0030435	View Revisions
2014-09-28 18:23	Quietust	Note Edited: 0030435	View Revisions
2014-09-28 22:36	BenLubar	Note Added: 0030442
2014-09-29 06:47	Footkerchief	Relationship added	related to 0003654
2014-12-21 12:35	BenLubar	Note Added: 0031415
2014-12-25 18:19	lethosor	Note Added: 0031475
2014-12-25 18:19	lethosor	Assigned To	=> lethosor
2014-12-25 18:19	lethosor	Status	new => confirmed
2015-12-28 18:33	BenLubar	Note Added: 0034247
2015-12-28 18:48	BenLubar	Note Edited: 0034247	View Revisions
2015-12-28 20:11	BenLubar	Note Added: 0034250
2016-01-02 16:36	BenLubar	Note Added: 0034277

Notes
(0030433) BenLubar (reporter) 2014-09-28 15:45	Observation: @ is CP437 0x40 red is the 4th color in Dwarf Fortress (ignoring intensities) black is the 0th color in Dwarf Fortress There's probably some uninitialized data being read somewhere.

(0030435) Quietust (reporter) 2014-09-28 17:51 edited on: 2014-09-28 18:23	If you single-step through the movie, the frames with black-on-red-@ are all misaligned, drawing from some point in the middle of the screen and corrupting anything that would've been off the right edge (and with everything past the bottom edge shifted to the left). The bug described in 0003654 sounds similar to this.

(0030442) BenLubar (reporter) 2014-09-28 22:36	I wonder if it has to do with how the file is compressed... The file (and also pretty much every other Dwarf Fortress file) is compressed in chunks, with each chunk's uncompressed size being more or less constant. Maybe all the broken frames go over chunk boundaries.

(0031415) BenLubar (reporter) 2014-12-21 12:35	screen capture of dwarf fortress: https://www.youtube.com/watch?v=fBVATWnlw1Y [^] external encoder using the same cmv file: https://www.youtube.com/watch?v=c5CUZhpRryA [^]

(0031475) lethosor (manager) 2014-12-25 18:19	You mentioned that this occurs with "large" movies in the title - does it occur with 80x25 movies at all? Have you noticed a minimum resolution where this occurs?

(0034247) BenLubar (reporter) 2015-12-28 18:33 edited on: 2015-12-28 18:48	Okay, it seems I deleted the original repro when I was cleaning out some old stuff, so here's a new repro: http://dffd.bay12games.com/file.php?id=6190 [^] Pick any of the three files. They're all 91x34 and they all exibit the same behavior. I've modified a UI experiment I was working on to play those CMVs and output a recording to last_record.cmv: http://dffd.bay12games.com/file.php?id=11574 [^] The UI experiment can demonstrate that the CMV files are not corrupted.

(0034250) BenLubar (reporter) 2015-12-28 20:11	Ok, looks like the third CMV file is actually corrupt, possibly from the screen size changing while it was recording, but I'm not sure. The first two are fine, though.

(0034277) BenLubar (reporter) 2016-01-02 16:36	Here's a fixed version of the third CMV: http://dffd.bay12games.com/file.php?id=11577 [^] (it was indeed corrupted by screen size changing)