0010057: In combat/death, units are not 'struck down' or die and remain alive after being converted into corpse objects/items

Notes
(0036013) chaosvolt (reporter) 2016-10-31 00:06	I find it questionable that it's actually related to the "can't eat sentient meat/use for crafting" bug, unless the same update that borked that introduced this. Otherwise, it is purely a code regressing Toady somehow committed and (as stated by a FotF reply) is uncertain as to how it occurred.

(0036015) FantasticDorf (reporter) 2016-10-31 05:18 edited on: 2016-11-02 13:05	Id agree with regression also, as the exploit in the description shows, the 'unit_bp_health_flags' or just health flags in diagnosis (and more specifically individual health readings on the (Z) interface) doesn't have a health state to define death, only decomposition through body part BP. On top of regressional bugs with creatures via other code structures having their own health screens via unseeable GUI/UI to experience the same thing, with implications that a lot of behaviour could be shared between units as seen in > http://www.bay12games.com/dwarves/mantisbt/view.php?id=10059 [^] and (http://www.bay12games.com/dwarves/mantisbt/view.php?id=4366 [^] <- = -> http://www.bay12games.com/dwarves/mantisbt/view.php?id=797 [^]) If a unit never truly dies its item corpse is only ever recognized as a 'living' item corpse, since its unit ID is separate and alive from the object despite the transition into a corpse registered as death. Its entity even after item corpse destruction is still around but non interfacable. Items that are strictly BP anatomical (also tied to decoration ethics) such as teeth and ivory, are unworkable because they still belong to the abstract creature ID as its physical body, given that they are only usable when they are dead for crafting, and these items remain as part of the creature's alive state, hence why ghosts rise from lost teeth despite everything else being entombed properly or animated dead INSIDE the tomb coffin rising because of a improper burial. The ethic system must work in such a way that unless the creature is classed as huntable (Work orders - Forbid (O -> F)) via [ETHIC:KILL ANIMAL] and [ANIMAL PRODUCTS] nothing else can be done, as separate to the ethic, [ANIMAL_PRODUCTS] allows for products like meat leather and bones normally as well as milk and hair/yarn. (Ethic animals = Workable item corpses, but animals are exclusive and hard-coded anyway dead or not for corpse item processing so hunting works right,[ANIMAL PRODUCTS] = Meat, bones, products from animals carrying the allowed classes id of ethic animals, includes sentients but sentients are not 'huntable' animals as defined by the FORBID screen which even when set to allow sentients, fails) The ethics for entity butchery and both classes of decoration also forbid using those materials. Trolls that are slaughtered for instance, don't 'die', as their tusks and meat are discarded from use post slaughter as a un-legitimate ethic kill even with the right site entity ethics [EAT_SENTIENT_OTHER], though troll meat and objects brought on embark are fine (troll ivory goblets etc) while collected on site materials are put to the refuse pile. > This suggests all death is broken to some degree, even slaughtering interactions where the unit is immediately destroyed whilst in a alive state. None of the objects from a slaughtered intelligent will be defined as {{forbidden}} as your workers handle them and move them to the refuse piles, and remain with the creatures ID, unusable. [Correction] > The state of a animated corpse unit is set back into a 'huntable' state where it can be butchered (now stripped of its intelligence) though its materials if ethically controversial will still be restricted. Pets would be allowed since the only ethic that covers is [ETHIC:KILL_ANIMAL] and the process has been completed. The ID states after zombification remains, as the illegal proceeds will still be put to refuse if it is still listed as 'alive' and has a active id while still tied to a destroyed corpse You can't butcher a item corpse which is defined as 'alive', since that would require slaughtering it, as a huntable class of creature like a non-intelligent animal it can be butchered but this is factionally subjective, as only wild animals are huntable, not fortress member pets. If its wild its legitimate, if its tamed then its not huntable anymore because its a fortress entity citizen and need to be dead/slaughtered first, before the game runs it through. Apologies if this is a rehash of some of the description but questions around the link to butchery required addressing.

(0036024) FantasticDorf (reporter) 2016-11-02 13:25	Here is a relevant save that is also covering bugs from (0010059) on the same shared save. Only 1 download of it is requires to address both bugs in this current form. http://dffd.bay12games.com/file.php?id=12543 [^] [^] Areas of interest have (N)otes around them. For this specific bug there is... > A kiwi on the surface engaged in combat with a snake, because the snake only has 1 method of attack, it uses that. Relatably, biting is considered a lethal form of combat above brawling (and on animals because its not a sheath/unsheathed weapon does not escalate the fight for the victim), the kiwi only scratches the snake with its legs while the snake delivers a venomous bite directly to the blood. The kiwi succumbs to the poison but is not struck down while still in combat dodging. (Image attached - http://puu.sh/s4i4W/2575cb65dd.png [^]) > In the caverns (north, north west z level 11-13) a group of troggs dies, headless example B is rendered unconscious when it is decapitated in combat logs and the other troglodyte is only remarkable for still having a tendon in the skull pulled and bust arteries after having its head cut off with a axe. Neither were struck down upon these fatal blows. (image attached - http://puu.sh/s4jdW/1c0534707b.png [^]) > The most northern trogg noted as (headless example A) had both its lungs attacked prior to death asphyxiating it with difficulty breathing, before giving into pain, having a axe lodged in its head (and removed) before having its head cut off before the dwarf remarked it was dead and disengaged. Curiously because it was already deprived of air & in pain it is not marked as unconscious when the head was removed. It was not 'stuck down' and its ID is still alive (Image attached of combat log - http://puu.sh/s4iv0/36ccee2386.png [^]) > The militia commander Asen Keskaluman (listed as a sword dwarf - immigrant) remarks at the item corpses despite the unit not really dying once they disengage combat before continuing station and being attacked again. > All deaths (image attached - http://puu.sh/s4g5U/59156c9186.png [^])

(0036039) FantasticDorf (reporter) 2016-11-07 07:47	As for a important note, there is significant research being done here within this dfforum thread http://www.bay12forums.com/smf/index.php?topic=161408.msg7250867#msg7250867 [^] Identified within Max's part of the research (via dfhack) is a workaround by disabling dead_dwarf true on the corpse object. I am ongoing my own research into BP relationships between the health system, especially in regards to external BP features like teeth and ivory. Application in using the latest alpha version 43.05 (at own risk) will allow you to properly probe the states with 'gui/gm-editor' on the save.

(0036692) Putnam (reporter) 2017-08-08 21:35	It was determined in the linked thread above that units are, indeed, actually killed, and "struck down" not being displayed is merely a display bug.

Issue History
Date Modified	Username	Field	Change
2016-10-27 09:39	FantasticDorf	New Issue
2016-10-29 09:39	FantasticDorf	Tag Attached: body parts
2016-10-29 09:39	FantasticDorf	Tag Attached: combat
2016-10-29 09:39	FantasticDorf	Tag Attached: corpse
2016-10-29 09:39	FantasticDorf	Tag Attached: death
2016-10-29 09:39	FantasticDorf	Tag Attached: decay
2016-10-29 09:39	FantasticDorf	Tag Attached: dismemberment
2016-10-29 09:39	FantasticDorf	Tag Attached: health
2016-10-29 09:39	FantasticDorf	Tag Attached: struck down
2016-10-31 00:06	chaosvolt	Note Added: 0036013
2016-10-31 05:18	FantasticDorf	Note Added: 0036015
2016-11-02 13:05	FantasticDorf	Note Edited: 0036015	View Revisions
2016-11-02 13:25	FantasticDorf	Note Added: 0036024
2016-11-02 13:32	FantasticDorf	Issue Monitored: FantasticDorf
2016-11-07 07:47	FantasticDorf	Note Added: 0036039
2017-08-08 21:35	Putnam	Note Added: 0036692
2018-01-19 10:12	hertggf	Issue Monitored: hertggf

Relationships