0002924: Moody dwarf has inconsistent display of quantities for primary vs. decorative items

Notes
(0011384) Chthon (reporter) 2010-08-01 21:34	Resulting artifact was wierd. "This is a donkey bone table. All craftmanship is of the highest quality." Thats it. No modifiers at all. 1200 Dwarfbucks too. In my experience all artifacts have 1 modifier per input material, with a minimum of one modifier ever. This one had 7 input materials and 0 modifiers.

(0011389) Footkerchief (manager) 2010-08-01 22:03	The lack of modifiers is 0002806.

(0011392) Chthon (reporter) 2010-08-01 22:43	Well if anything you have some info as to how this may have come about. Symptoms include requiring additional stacks of items that were not originally requested.

(0011395) Chthon (reporter) 2010-08-02 04:17 edited on: 2010-08-02 05:48	Update: I can now reproduce this error. Or at the least it has been reproduced. Like last time this was a bone carver mood. It only listed that it needed one stack of bones, but instead required three before it would proceed. Resulting artifact did not have any properties except for the base materials. I have saves from after the previous bugged artifact and during and after the second bugged artifact. Uploading them to DFFD now. Files uploaded in one zip: http://dffd.wimbli.com/file.php?id=2881 [^]

(0011397) Logical2u (manager) 2010-08-02 05:32	Chthon, if the dwarf only requests one type of item, it can be difficult to identify the number of items they require as there is often no break between the displays items. Essentially, "Needs bones" looks exactly the same as "Needs bones" and "Needs bones" back to back. So I'm not sure this is a bug beyond a duplicate of 0002806.

(0011398) Chthon (reporter) 2010-08-02 05:49 edited on: 2010-08-03 15:16	Check out the saves. Usually if they need 3 of an item it will display the need bones for 3 times as long. In this save he does not display it for 3 times as long. If you actually take a stopwatch to it it is the same length for all items. To put it another way, needs bone needs bones does not look exactly like needs bones. It looks instead like Neeeeds Boooones. Here I should have seen something like that but if you check the save out you do not. Update: Carpenter mood requiring bones had no issues of needing extra stacks of bones. This may just be a bone carver issue. Waiting to see a mood which legitimately requires 2 or more of an item in a row to show a save with the delay difference.

(0011520) Chthon (reporter) 2010-08-05 07:02 edited on: 2010-08-05 07:08	Just had a woodworker require 1 Time unit logs, 1 time unit bones. He took 2 logs and 1 stack of bones. Will update with whether or not he creates a bugged artifact here. Update: Was not bugged. Still the only moods that fail to produce correct artifacts for the inputs are bone crafter moods. Also Logical2U, just noticed that you failed to notice that both of the bugged artifacts required more than just bones to create. Both required 6+ ingredients and 2 extra bones that were not listed. One was 8 items before the 2 extra bone stacks.

(0011524) kwieland (reporter) 2010-08-05 11:06 edited on: 2010-08-06 07:48	I also have observed this bug but I don't have the save. In 40d, as Chthon said, the time (or if it was repeated in different places) was significant. .31 doesn't seem to have that. I have seen dwarfs only use one thing to make an artifact, which I wouldn't think would have a modifier. The fact that they got several items and they were not incorporated into the artifact is bizarre and definitely a bug. EDIT: Same thing again - requested "bones". Took three, and the finished artifact was only "a rhesus bone gauntlet" Nothing about the donkey and dog bones.

(0011544) Chthon (reporter) 2010-08-06 03:50	Just had a stonecrafter mood require 1 TU stone, 1 TU cloth. He took 3 stone and 1 cloth and made a correct artifact.

(0011585) Chthon (reporter) 2010-08-07 03:06 edited on: 2010-08-07 04:46	Just had a jewelcrafter require 1 TU cloth, 1 TU cut gems, 1 TU logs. He took 2 cloth 1 cut gems and 1 log. It's looking more and more that moods require 2 of the base item type and one or more of everything else. The bug then would be that bonecrafter moods instead require 3 stacks of bones and get bugged as a result. Edit: Looks like I had a bonecarver mood where he only required 2 stacks of bones. Still got a bugged artifact though. Perhaps total of the stacks has to be 30 bones? Will have to test this more.

(0012629) Quietust (reporter) 2010-09-14 07:00	The mechanics of mood item requirements seems to have changed, presumably as a result of object dimensions for stuff like bars, cloth, and thread - when the dwarf gets a mood, the job itself only has one entry for the primary material and it uses the "quantity" to determine how much it needs, just like how making rose gold requires "3 bars of gold, 1 bar of copper" (technically 450 and 150) rather than "1 bar of gold, 1 bar of gold, 1 bar of gold, 1 bar of copper"; as a result, the first ingredient only shows up for the 2 seconds indicative of a single ingredient. Subsequent ingredients will show up multiple times just as they have in the past.

(0017916) king doom (reporter) 2011-06-01 13:07	This might be intended behaviour, checking this involves timing how long the message for each requirement is onscreen before it changes. It could be the game is flashing up 'needs x' for three seconds, then flashing up the next requirement, which is also 'needs x', so it seems like it needs only one item instead of two or three.

(0017917) Quietust (reporter) 2011-06-01 13:59	king doom: read the original bug report again - it's clearly stated that the "pictures of skeletons" was only shown for 2 seconds, not the 6 seconds he was expecting.

Issue History
Date Modified	Username	Field	Change
2010-08-01 21:15	Chthon	New Issue
2010-08-01 21:34	Chthon	Note Added: 0011384
2010-08-01 22:03	Footkerchief	Note Added: 0011389
2010-08-01 22:03	Footkerchief	Relationship added	related to 0002806
2010-08-01 22:43	Chthon	Note Added: 0011392
2010-08-02 04:17	Chthon	Note Added: 0011395
2010-08-02 05:32	Logical2u	Note Added: 0011397
2010-08-02 05:48	Chthon	Note Edited: 0011395	View Revisions
2010-08-02 05:49	Chthon	Note Added: 0011398
2010-08-02 20:18	Chthon	Note Edited: 0011398	View Revisions
2010-08-03 15:16	Chthon	Note Edited: 0011398	View Revisions
2010-08-05 07:02	Chthon	Note Added: 0011520
2010-08-05 07:06	Chthon	Note Edited: 0011520	View Revisions
2010-08-05 07:08	Chthon	Note Edited: 0011520	View Revisions
2010-08-05 11:06	kwieland	Note Added: 0011524
2010-08-06 03:50	Chthon	Note Added: 0011544
2010-08-06 07:48	kwieland	Note Edited: 0011524	View Revisions
2010-08-07 03:06	Chthon	Note Added: 0011585
2010-08-07 04:46	Chthon	Note Edited: 0011585	View Revisions
2010-09-14 07:00	Quietust	Note Added: 0012629
2011-06-01 13:07	king doom	Note Added: 0017916
2011-06-01 13:59	Quietust	Note Added: 0017917
2011-06-04 14:53	Put	Issue Monitored: Put
2014-01-27 13:33	Footkerchief	Summary	Dwarf requires 3 stacks of bone even though he only drew one picture of skeletons => Moody dwarf has inconsistent display of quantities for primary vs. decorative items
2014-01-27 13:36	Footkerchief	Relationship added	related to 0000159