0006391: Openly stealing owned items does not make you a Criminal

(0024219)
Quietust (reporter)
2013-11-22 16:57

If I use DFHack to manually make myself a criminal within the relevant entity (replacing the relevant histfig/entity links), then the townspeople correctly treat me as a criminal, so the only problem seems to be with recognizing the crime in the first place.

(0024220)
JasonMel (reporter)
2013-11-23 05:05

Maybe it has to be witnessed by an owner?

(0024221)
Quietust (reporter)
2013-11-24 05:47
edited on: 2013-11-24 05:52

The owners were definitely there to witness me walking off with their stuff. I even walked back inside afterwards and talked to them, which is how I knew the theft hadn't been recognized.

(0024222)
smjjames (reporter)
2013-11-24 06:56

I know I posted on a thread, but how did you examine histfig/entity links? Not sure if you are referring to something other than simply retiring somewhere and checking legends.

(0024223)
Quietust (reporter)
2013-11-24 08:38

I used DFHack during gameplay to directly examine my adventurer's historical figure record, which is where that sort of stuff is stored. I did so both in 0.34.11 and 0.28.181.40d, which is how I confirmed that it used to be working correctly.

(0024224)
smjjames (reporter)
2013-11-24 08:49
edited on: 2013-11-24 09:35

<s>How did you do that though with DFhack?</s>

Actually, I'll just take the question over to the DFhack thread.

(0024578)
Quietust (reporter)
2014-02-27 12:25
edited on: 2014-02-27 12:26

Upon closer investigation (i.e. disassembly diving), I see why theft isn't being recognized anymore - the logic for detecting theft only looks for civzones of types 1 (Craft Shop), 3 (Weaponsmith's Shop), 4 (Armorsmith's Shop), 5 (General Store), and 6 (Food Shop), which were used for the old-style shops in versions 0.31.12 and earlier, but shops in the current version are all of type 0 (Home), so it ignores them.

(0025570)
Quietust (reporter)
2014-07-10 12:24
edited on: 2014-07-10 12:24

Incidentally, the issue I reported at 0005654 (which turned out to not be a bug) is actually related to this - if those civzones WERE being assigned the traditional types (instead of being left as "Home"), this would be working properly.

(0026863)
FireWarrior2112 (reporter)
2014-07-18 08:16

I can reproduce this bug, in front of store owners or not, I can simply take what i want out of any (human) store and walk out without my status changing. interesting to note, it says in the event log that i stole, but he isn't aware. I can even take all the armour i want from an armour shop, put it on right in front of him and go and have a conversation without him being aware i just stole half his merchandise then walk out.

(0030034)
smjjames (reporter)
2014-09-08 08:09

Same thing for 40.11 in fortresses, though what passes for stores in the fortresses don't seem to have any particular merchant to talk to. I can take owned (has the coin symbol) stuff right in view of various people and can walk out with a full set of stolen armor and other stuff without people reacting.

(0031620)
Toady One (administrator)
2014-12-31 11:55

The relevant code is gone now, and we'll have to wait for the start scenario property rewrite to get back to this.

Issue History
Date Modified	Username	Field	Change
2013-11-22 12:21	Quietust	New Issue
2013-11-22 16:57	Quietust	Note Added: 0024219
2013-11-23 05:05	JasonMel	Note Added: 0024220
2013-11-24 05:47	Quietust	Note Added: 0024221
2013-11-24 05:52	Quietust	Note Edited: 0024221	View Revisions
2013-11-24 06:56	smjjames	Note Added: 0024222
2013-11-24 08:38	Quietust	Note Added: 0024223
2013-11-24 08:49	smjjames	Note Added: 0024224
2013-11-24 09:35	smjjames	Note Edited: 0024224	View Revisions
2013-11-24 09:35	smjjames	Note Edited: 0024224	View Revisions
2013-11-29 14:55	Footkerchief	Summary	Stealing owned items does not make you a Criminal => Openly stealing owned items does not make you a Criminal
2013-11-29 14:55	Footkerchief	Relationship added	related to 0005242
2014-02-27 12:25	Quietust	Note Added: 0024578
2014-02-27 12:26	Quietust	Note Edited: 0024578	View Revisions
2014-02-27 21:35	Footkerchief	Assigned To	=> Footkerchief
2014-02-27 21:35	Footkerchief	Status	new => acknowledged
2014-07-10 11:48	Footkerchief	Tag Attached: binary patch
2014-07-10 12:24	Quietust	Note Added: 0025570
2014-07-10 12:24	Quietust	Note Edited: 0025570	View Revisions
2014-07-18 08:16	FireWarrior2112	Note Added: 0026863
2014-09-08 08:09	smjjames	Note Added: 0030034
2014-09-08 09:05	Footkerchief	Status	acknowledged => confirmed
2014-09-08 16:02	Mopsy	Issue Monitored: Mopsy
2014-12-31 11:55	Toady One	Note Added: 0031620
2014-12-31 11:55	Toady One	Status	confirmed => resolved
2014-12-31 11:55	Toady One	Resolution	open => no change required
2014-12-31 11:55	Toady One	Assigned To	Footkerchief => Toady One

Notes
(0024219) Quietust (reporter) 2013-11-22 16:57	If I use DFHack to manually make myself a criminal within the relevant entity (replacing the relevant histfig/entity links), then the townspeople correctly treat me as a criminal, so the only problem seems to be with recognizing the crime in the first place.

(0024220) JasonMel (reporter) 2013-11-23 05:05	Maybe it has to be witnessed by an owner?

(0024221) Quietust (reporter) 2013-11-24 05:47 edited on: 2013-11-24 05:52	The owners were definitely there to witness me walking off with their stuff. I even walked back inside afterwards and talked to them, which is how I knew the theft hadn't been recognized.

(0024222) smjjames (reporter) 2013-11-24 06:56	I know I posted on a thread, but how did you examine histfig/entity links? Not sure if you are referring to something other than simply retiring somewhere and checking legends.

(0024223) Quietust (reporter) 2013-11-24 08:38	I used DFHack during gameplay to directly examine my adventurer's historical figure record, which is where that sort of stuff is stored. I did so both in 0.34.11 and 0.28.181.40d, which is how I confirmed that it used to be working correctly.

(0024224) smjjames (reporter) 2013-11-24 08:49 edited on: 2013-11-24 09:35	<s>How did you do that though with DFhack?</s> Actually, I'll just take the question over to the DFhack thread.

(0024578) Quietust (reporter) 2014-02-27 12:25 edited on: 2014-02-27 12:26	Upon closer investigation (i.e. disassembly diving), I see why theft isn't being recognized anymore - the logic for detecting theft only looks for civzones of types 1 (Craft Shop), 3 (Weaponsmith's Shop), 4 (Armorsmith's Shop), 5 (General Store), and 6 (Food Shop), which were used for the old-style shops in versions 0.31.12 and earlier, but shops in the current version are all of type 0 (Home), so it ignores them.

(0025570) Quietust (reporter) 2014-07-10 12:24 edited on: 2014-07-10 12:24	Incidentally, the issue I reported at 0005654 (which turned out to not be a bug) is actually related to this - if those civzones WERE being assigned the traditional types (instead of being left as "Home"), this would be working properly.

(0026863) FireWarrior2112 (reporter) 2014-07-18 08:16	I can reproduce this bug, in front of store owners or not, I can simply take what i want out of any (human) store and walk out without my status changing. interesting to note, it says in the event log that i stole, but he isn't aware. I can even take all the armour i want from an armour shop, put it on right in front of him and go and have a conversation without him being aware i just stole half his merchandise then walk out.

(0030034) smjjames (reporter) 2014-09-08 08:09	Same thing for 40.11 in fortresses, though what passes for stores in the fortresses don't seem to have any particular merchant to talk to. I can take owned (has the coin symbol) stuff right in view of various people and can walk out with a full set of stolen armor and other stuff without people reacting.

(0031620) Toady One (administrator) 2014-12-31 11:55	The relevant code is gone now, and we'll have to wait for the start scenario property rewrite to get back to this.